Backend + Fix: Improve active Perks Handling - Githubissues

hannibal002 / SkyHanni

SkyHanni is a 1.8.9 Minecraft Mod for Hypixel SkyBlock.

https://discord.gg/skyhanni-997079228510117908

GNU Lesser General Public License v2.1

335 stars 195 forks source link

Backend + Fix: Improve active Perks Handling #2838

Closed j10a1n15 closed 3 weeks ago

j10a1n15 commented 3 weeks ago

What

Refactored ElectionAPI and MayorData to be less of a pain to work with active perks. Also wanted to move the renamed files into their own package, it didnt allow me to move the MayorData files though test

Changelog Fixes

Fixed issues where the Carnival Ticket claim feature would trigger even when a carnival isn't active. - j10a1n15

Changelog Technical Details

Improved the handling of active mayor perks, making it less annoying to work with. - j10a1n15

github-actions[bot] commented 3 weeks ago

I have detected some issues with your pull request:

Title issues: Unknown category: 'Backend Fix', valid categories are: Feature, Improvement, Fix, Backend, Remove and expected categories based on your changes are: Backend

Please fix these issues. For the correct format, refer to the pull request template.

github-actions[bot] commented 3 weeks ago

I have detected some issues with your pull request:

Title issues: Unknown category: 'Backend Fix', valid categories are: Feature, Improvement, Fix, Backend, Remove and expected categories based on your changes are: Fix, Backend

Please fix these issues. For the correct format, refer to the pull request template.

github-actions[bot] commented 3 weeks ago

One or more Detekt Failures were detected:

DianaProfitTracker.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
GriffinBurrowHelper.kt#L3: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end. This should then be followed by pre-processed imports.
ElectionAPI.kt#L100: Dispatcher IO is used without dependency injection.
ScoreboardElementMayor.kt#L12: Missing newline after "{"
ScoreboardElementMayor.kt#L35: Missing newline after "{"

github-actions[bot] commented 3 weeks ago

One or more Detekt Failures were detected:

ElectionAPI.kt#L100: Dispatcher IO is used without dependency injection.

github-actions[bot] commented 3 weeks ago

One or more Detekt Failures were detected:

ElectionAPI.kt#L100: Dispatcher IO is used without dependency injection.