search

hannibal002 / SkyHanni

SkyHanni is a 1.8.9 Minecraft Mod for Hypixel SkyBlock.
https://discord.gg/skyhanni-997079228510117908
GNU Lesser General Public License v2.1
335 stars 195 forks source link

Improvement: Option for optimal speed warning when not wearing rancher's #2859

Open Obsidianninja11 opened 2 weeks ago

Obsidianninja11 commented 2 weeks ago

What

Made optimal speed warning warn when not wearing rancher's boots. It will send a message that doesn't have the clickable /setmaxspeed when not wearing rancher's boots. Haven't tested it yet, since i did it in github editor, but it should work unless i skill issued with formatting tested it when i added config

Changelog Improvements

jani270 commented 2 weeks ago

How is this a bug fix? This was/is the intended behavior of the feature.

Obsidianninja11 commented 2 weeks ago

How is this a bug fix? This was/is the intended behavior of the feature.

Seems like Hanni accidentally disabled it entirely when not wearing rancher's see #2413

jani270 commented 2 weeks ago

How is this a bug fix? This was/is the intended behavior of the feature.

Seems like Hanni accidentally disabled it entirely when not wearing rancher's see #2413

accidentally

"Now warns only when actually farming and wearing Rancher Boots."

github-actions[bot] commented 2 weeks ago

One or more Detekt Failures were detected:

Obsidianninja11 commented 2 weeks ago

I suppose i can add a config to Only Warn With Rancher's tomorrow, but seems quite useless imo

qtlunya commented 2 weeks ago

Yeah, I would prefer if this was configurable. It can be useful to have, but I don't want to be notified if I'm pest farming and going at, say, 329 speed instead of 328. Also on Bingo where it's hard to get the exact speed right or you may even be using a different farm design.

github-actions[bot] commented 2 weeks ago

I have detected some issues with your pull request:

Title issues: PR has category 'Improvement' which is not in the changelog. Expected categories: Fix

Please fix these issues. For the correct format, refer to the pull request template.

github-actions[bot] commented 2 weeks ago

I have detected some issues with your pull request:

Body issues: Change should start with 'Added' instead of 'Add' in text: Add an option to send optimal speed warning when not wearing Rancher's Boots.

Please fix these issues. For the correct format, refer to the pull request template.

github-actions[bot] commented 2 weeks ago

One or more Detekt Failures were detected: