hannibal002 / SkyHanni

SkyHanni is a 1.8.9 Minecraft Mod for Hypixel SkyBlock.
https://discord.gg/skyhanni-997079228510117908
GNU Lesser General Public License v2.1
335 stars 195 forks source link

Fix: Scoreboard Hiding #2892

Closed j10a1n15 closed 1 week ago

j10a1n15 commented 2 weeks ago

What

This Pull Request improves/fixes the vanilla scoreboard hiding to use a mixin, instead of the other render method. Wasn't able to test this yet because it doesn't build rn (com.gradleup.shadow is down or smth idfk) Ran it using the GitHub build, works really well (even with Apec) I hope it has a better spec combat, because rn it still flickers apparently (awesome how this didn't get reported on SkyHanni)

Changelog Fixes

github-actions[bot] commented 2 weeks ago

I have detected some issues with your pull request:

Body issues: Change should start with 'Fixed' instead of 'Fix' in text: Fixes Scoreboard flicker when using Apec and Custom Scoreboard.

Please fix these issues. For the correct format, refer to the pull request template.

github-actions[bot] commented 1 week ago

One or more Detekt Failures were detected: