Closed jugmac00 closed 3 years ago
Hi Hanno,
thanks for the feedback.
Right, I overlooked that you committed the script with +x already. Sorry for that.
The script change would have not been in the history if you clicked squash merge. In case you did not know, there are three options to merge a pull request: merge, squash and merge, and rebase.
I have force-pushed a single, clean commit with no script touching and the corrected readme - just in case you change your mind.
Anyway, cheers!
Agreed that some doc is good. But the +x is not needed (it's already committed as an executable to the repo) and the useless change of the script itself shouldn't be in the history. I'll add some docs myself and will close.