Use requirements.txt for dependencies

hannob / vacdec

Python script to decode the EU Covid-19 vaccine certificate

The Unlicense

242 stars 89 forks source link

Use requirements.txt for dependencies #6

Closed guerda closed 3 years ago

guerda commented 3 years ago

I created a dependencies file requirements.txt which includes the current versions of the required files. I also updated the README file, to use this.

hannob commented 3 years ago

You're pinning to specific versions, this looks like a bad idea as it would force downgrades as soon as there's a new version of those packages. I also don't really see a need for this for such a simple script.

guerda commented 3 years ago

Fair point, I usually do this as good practice, even for the smallest scripts.

Fixing it to the working versions is recommended for reproducibility. Maybe you can add the versions wgic you tested it with? The versions I specified in this PR were the latest ones and it worked fine.