search

hannobraun / inotify-rs

Idiomatic inotify wrapper for the Rust programming language
ISC License
261 stars 65 forks source link

Update minimum supported Rust version #194

Closed hannobraun closed 2 years ago

hannobraun commented 2 years ago

As per the the CI configuration, the minimum supported Rust version is 1.47.0: https://github.com/hannobraun/inotify-rs/blob/7d2fc13b275adfe8f08b85bccf9e74a1cc6be83c/.github/workflows/rust.yml#L15

This makes the CI build fail, because the MSRV of Tokio is currently 1.49.0: https://github.com/tokio-rs/tokio#supported-rust-versions

Here's a failing build: https://github.com/hannobraun/inotify-rs/runs/7464645347

I'm not sure what the best MSRV would be. We could be conservative, and just upgrade to 1.49.0 to make the CI build again; or we could upgrade to the latest version, so we won't have this problem again for a while; or anything in between. If any users of inotify-rs need to support older Rust versions, please speak up.

hannobraun commented 2 years ago

Addressed in #196. Thank you, @talklittle!