Update dependency `bitflags` to v2?

hannobraun / inotify-rs

Idiomatic inotify wrapper for the Rust programming language

ISC License

254 stars 64 forks source link

Update dependency `bitflags` to v2? #210

Closed LeoniePhiline closed 9 months ago

LeoniePhiline commented 9 months ago

bitflags v2 became available in March 2023: https://crates.io/crates/bitflags/versions

Major changes: https://github.com/bitflags/bitflags/releases/tag/2.0.0

Maybe it is feasible to upgrade from v1 to v2?

hannobraun commented 9 months ago

Hey @LeoniePhiline, thank you for opening this issue!

That upgrade does indeed look feasible. I'd be happy to accept a pull request!

hannobraun commented 9 months ago

I can't think of a reason to remove any of those implementations. I think it's probably best to keep all of them around. (I see that's what you've already done in your pull request :+1:)

hannobraun commented 9 months ago

Addressed in #211.