search

hannorein / rebound

💫 An open-source multi-purpose N-body code.
https://rebound.readthedocs.io/
GNU General Public License v3.0
849 stars 219 forks source link

acos2 is now static #647

Closed hannorein closed 1 year ago

hannorein commented 1 year ago

@dtamayo I noticed that the acos2 function did not have the reb_ prefix but was part of the shared library. That could lead to issues when there is another library implementing the same function. It looks like we never use the function outside of tools.c so I have made it static. It looks like you also don't use it in reboundx. But maybe I'm missing something. Asking you because you implemented it. If not, I'll merge this in.

dtamayo commented 1 year ago

Yup, this can be static! I needed it for reb_vec3d so I changed things when they were in REBOUNDx, but not anymore. Thanks for catching it. There's no rush on this, but could we make a new REBOUND version once the vec3d stuff is settled? I need the new REBOUND version to pass the REBOUNDx unit tests. Thanks again!

hannorein commented 1 year ago

done