search

hannorein / rebound

💫 An open-source multi-purpose N-body code.
https://rebound.readthedocs.io/
GNU General Public License v3.0
820 stars 217 forks source link

Adding ObliquityEvolution.ipynb to ipython_examples #674

Closed michaelkmpoon closed 1 year ago

michaelkmpoon commented 1 year ago

Adding Obliquity Evolution tutorial, which reproduces Fig. 3 in Millholland+Laughlin2019 and Lu+2023.

Authored by Dang Pham + Michael Poon (equal contribution)

dtamayo commented 1 year ago

This looks like a really nicely annotated example! I think the place for it would be in REBOUNDx rather than REBOUND. In order to run the automatic unit tests in a reasonable time, I think you would have to change the max times so that the whole notebook runs in ~20 seconds, but there could be text saying what times should be chosen to get capture etc. Of course this might be part of @hannorein 's course, in which case feel free to disregard!

hannorein commented 1 year ago

It is part of my course. And your feedback is identical to mine ;-)

dtamayo commented 1 year ago

A pull request with no comment for 2 weeks felt like a trap :)

michaelkmpoon commented 1 year ago

Thanks @dtamayo and @hannorein for the feedback! @dangcpham and I made changes and submitted a pull request to REBOUNDx. :D