Remove Python 2.7 dependency from workflow

hannorein / rebound

💫 An open-source multi-purpose N-body code.

https://rebound.readthedocs.io/

GNU General Public License v3.0

820 stars 217 forks source link

Closed dangcpham closed 1 year ago

dangcpham commented 1 year ago

As of June 19, GitHub workflow no longer supports Python 2.7 by setup-python (https://github.com/actions/setup-python/issues/672). This pull request removes 2.7 dependency from the workflow.

Note: there is still a Python 2.7 ipynb dependency. Not sure how to work around this as it is there to test python 2.7 exclusively.

hannorein commented 1 year ago

Thanks. This seem good, but why does it still fail? I'm confused.

hannorein commented 1 year ago

Oh, sorry. You mentioned it, the notebooks. So that needs to be updated too.

dangcpham commented 1 year ago

All tests passed now.

Do you still want to test for Python 2.7 in the future? It seems there are some hacks around to implement Python 2.7 in setup-python.

hannorein commented 1 year ago

Excellent. Thanks!

I don't think there is a need to keep testing for 2.7...