search

hannorein / rebound

💫 An open-source multi-purpose N-body code.
https://rebound.readthedocs.io/
GNU General Public License v3.0
844 stars 219 forks source link

TRACE Main PR #771

Closed tigerchenlu98 closed 4 months ago

tigerchenlu98 commented 5 months ago

Hi Hanno,

Here's the hopefully final PR! Things look pretty clean (except the notebooks, don't think there's a way around that). I replaced all the examples, the only one which is doing worse is PrimordialEarth - not sure why, I need to look into it more.

Let me know if everything looks good!

Tiger

hannorein commented 5 months ago

Wow! This looks great! I looked over it just now and only found very minor things. I want to stare at it a little longer, just to make sure. But I think we're basically done!

hannorein commented 4 months ago

Please merge in my branch tigerchenlu98-newTRACE4_FULL_fbs for some minor changes/cleanup.

Then see the two small queries above.

tigerchenlu98 commented 4 months ago

Both done!

hannorein commented 4 months ago

I pushed a few updates to the notebooks (you can merge my tigerchenlu98-newTRACE4_FULL_fbs branch again). Mainly typos, consistency things.

Not sure why the windows tests sometimes (?) fail. Does not seem related to TRACE.

We either need to revert the primordial earth example to use mercurius, or update it (it still mentions Mercurius), depending on what your tests show.

hannorein commented 4 months ago

Squash merged. I kept the old Primordial Earth for now. We can update it any time if we want to.