hannorein / rebound

💫 An open-source multi-purpose N-body code.
https://rebound.readthedocs.io/
GNU General Public License v3.0
817 stars 216 forks source link

Missing Inertial<->DHC transform in TRACE #772

Closed tigerchenlu98 closed 1 month ago

tigerchenlu98 commented 1 month ago

There was a conversion between DHC <-> Inertial for the FULL PERI prescriptions that somehow got lost in some of the updates: this was making the violent system behave very poorly. I've corrected it and re-checked the relevant examples, and everything seems to be working as expected again.

The unit tests didn't catch this because the pericenter test was commented out. I've added it back in and confirmed that it fails if the transformation is not there, and passes otherwise.

Also fixed a typo in the documentation :)

hannorein commented 1 month ago

Thanks for catching that.