search

hannseman / homebridge-mi-hygrothermograph

Homebridge plugin for the Xiaomi Mi Bluetooth Temperature and Humidity Sensor
MIT License
266 stars 52 forks source link

fix: lint prettier errors #144

Closed ormisum closed 3 years ago

hannseman commented 3 years ago

Hi! I see that you've created a fork to support the CGDK2. I would be glad to get a PR to this repository. Looks like it didn't require that much of a change to implement? Don't really see the point of creating fragmentation.

ormisum commented 3 years ago

Hi! as there was no answer on issue #141 i assumed this repo was not maintained anymore. Sure, can you support me a little to get this merged? Main difference here is that you need to listen on SERVICE_DATA_UUID = "fdcd"; Also the parsing is different. My skills are modest, but the code is working, i tested it successfully for almost a month now with the CGDK2. If I'd try to open an initial PR, would you help me with the refactoring and adapting the tests?

hannseman commented 3 years ago

For sure! Yeah the best approach might be to add a new parser for this and select the correct parser depending on the service uuid in the scanner.