Mi Flora support

[Kylmakalle]

Hello @hannseman. I would Like to introduce a full support for Mi Flora accessories. Main purpose if this PR is to use one (non-conflicting with other) plugin for all devices using BLE broadcast advertisement packets. Closes #44 and https://github.com/honkmaster/homebridge-mi-flower-care/issues/4

Everybody can test this with terminal command in homebridge. (Make sure to have a config backup)

sudo -E -n npm install -g Kylmakalle/homebridge-mi-hygrothermograph

• Added new (backward-compatible) type property for accessory
• Exposed Fertility as Light Sensor, Moisture as Humidity Sensor and Illuminance as Light Sensor
• Added MQTT support for exposed values.
• Updated UI config scheme with dynamic support for both Hygrothermograph and Mi Flora accessory types.
• Fully unit-tested and linted code
• Tested IRL

Accessories view

I've tested it with my plant and it looks pretty fine.

Config UI

Downsides

• Plant Humidity will affect whole room humidity in Home app (can be fixed with separate room)
• Plant Fertility is exposed as Light Sensor due to most proper value support, which also affects whole room Light level in Home app. Subject to change.

[github-actions[bot]]

File	Coverage	Lines	Branches		Missing
All files	97%	98%	95%	:x:
lib/accessory.js	95%	97%	94%	:x:	107 125 148 356 381 527 641

Minimum allowed coverage is 100%

Generated by :monkey: cobertura-action against d13268dc7f95c93d9629c2c4d89f7a11d533d9b9

[hannseman]

@Kylmakalle cool thanks! 🤩

As you've noticed I've been quite slow at responding to this PR, it's a bit hectic for me at the moment but probably calm down around next week. Then I'll give this a review! Thanks again.

[Kylmakalle]

Hey @hannseman, it's alright! I hope that you are keeping safe and well.

I've added some more tests to acquire maximum coverage hit rate while you're taking your time.

[kinoushe]

Great work! I've been running a separate bridge just for Mi Flora for a long time, so it's great to be able to combine them.

The only issue I'm having is with FakeGato not working with the Mi Flora accessories. I have it enabled for each accessory but no graph data is showing in Eve, even after a few hours and restarts. The Hygrothermograph accessories are still working correctly.

[hannseman]

Hi @kinoushe, I think that graphing is only supported for humidity and temperature in Eve. See https://github.com/honkmaster/homebridge-mi-flower-care/issues/5

Or do you mean that not even humidity and temperature is graphed for the Mi Flora devices?

[kinoushe]

Hi @hannseman, yes - I mean just the humidity and temperature, the real time information is present and correct, but it isn't downloading these graphs. The "dot" just pulses in the top right bar in Eve but never updates the graphs for the Mi Flora items.

I've removed the previous Mi Flora bridge and accessories, so I don't think it's a name/device conflict from the previous setup.

[hannseman]

Right! Think I found the issue. For Mi Flora devices we keep track of moisture separate from the humidity emitted by the “old” sensors. In the call to add an entry to fake-gato we guard that humidity is set before adding it:

https://github.com/hannseman/homebridge-mi-hygrothermograph/blob/f6c9ff5db738c63757b979512f49e24c2e233821/lib/accessory.js#L418

I’ll push a fix in the weekend, thanks for the report 👍

[kinoushe]

Oh excellent, thanks @hannseman! I'll report back when the fix is out.

[hannseman]

@kinoushe, just pushed 3.3.1 to npm with a possible fix.

[kinoushe]

The Eve graphs are now working correctly with this fix 👍 Thanks again @hannseman!