hanoii / platformsh2slack

An adapter from platform.sh webhook to slack incoming webhook that can be hosted on a platform.sh app.
20 stars 5 forks source link

Fix routes, redirects, and basic auth #5

Closed jameswilson closed 5 years ago

jameswilson commented 6 years ago
screen shot 2018-09-25 at 2 26 51 am
hanoii commented 5 years ago

Hey @jameswilson , thanks for this. I was meaning to get to it, and pretty much accept it, but wanted to give it a proper look. Will try to do it soon.

jameswilson commented 5 years ago

Hi @hanoii just a friendly ping. We're definitely using these changes successfully in our teams at @BluesparkLabs. We love the ability to see the HTTP Auth strings right there in Slack.

hanoii commented 5 years ago

@jameswilson I merged it anyway, I can come up to any changes later, but see if you can check on my comment above in the code.