search

hans / puddle-world

1 stars 1 forks source link

switch from `unique` ontology function to `find` #10

Closed hans closed 5 years ago

hans commented 5 years ago

This allows us to play nicely with EC, which doesn't allow implicit stateful evaluation. (IIRC that was the motivation for changing this, right @CatherineWong ?)

Not yet tested — trying to get my setup to play nicely with EC and that's blocking at the moment.

hans commented 5 years ago

We resolved to change the pyccg setup to match what is already present in the DreamCoder tests. That means passing a context representation to every individual lexical meaning representation. Ugly, but possibly the easiest way to keep the two frameworks happy. Will require hacks on the pyccg side, or great perf improvements in program search, or both.

hans commented 5 years ago

Going to push this off until I've made some good progress on pyccg perf improvements, though — that's certainly higher-priority, and the stopgap measure of translating unique -> ec_unique seems to be working okay (correct @CatherineWong ?)

CatherineWong commented 5 years ago

Actually pretty close to wanting to use this properly. If it isn't too hard (and will only just slow down enumeration) this would be good to have in.

hans commented 5 years ago

Okay, and the current setup is blocking?

I can refit the ontology to make it work if so. I'd just rather spend that time banging on performance improvements if it's not blocking. Let me know.

Catherine Wong notifications@github.com schrieb am Do., 27. Juni 2019, 17:34:

Actually pretty close to wanting to use this properly. If it isn't too hard (and will only just slow down enumeration) this would be good to have in.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/hans/puddle-world/pull/10?email_source=notifications&email_token=AAABWOHUSFYUWLEW3OF7KYTP4UW7XA5CNFSM4H2S724KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYOGYA#issuecomment-506520416, or mute the thread https://github.com/notifications/unsubscribe-auth/AAABWOGGI3C4CX4RNDTA353P4UW7XANCNFSM4H2S724A .

hans commented 5 years ago

We went for a custom ontology conversion function which bridges the different ontologies between EC and pyccg instead. May come back to this for the longer-term solution..