hans / puddle-world

1 stars 1 forks source link

Use new EC subdirectory structure #17

Closed CatherineWong closed 5 years ago

CatherineWong commented 5 years ago

Integrates changes from https://github.com/hans/puddle-world/pull/8 using the latest version of Puddleworld.

hans commented 5 years ago

Thanks for handling this @CatherineWong ! Does this mean EC is ready to be used as a Python package? Do you know what the status of that is?

lcary commented 5 years ago

Thanks for handling this @CatherineWong ! Does this mean EC is ready to be used as a Python package? Do you know what the status of that is?

Hi @hans, I couldn't help but notice your comment.

Currently all I've done is the initial step of refactoring the directory structure of EC, but making it into a proper Python package is on my radar.

I should be able to get a PR together that adds a setup.py file for EC by ~next week~. After that, I can push it up to PyPI so that it can be pip-installed and easily imported, and then puddle-world shouldn't have to manipulate the sys.path to use EC code. Feel free to reach out with any other questions.

EDIT: I still haven't got around to packaging EC to be pip-installable, as a few other things have come up, but if you are interested in this please reach out me and I will do it!