search

hans / puddle-world

1 stars 1 forks source link

Puddleworld updates pending EC refactor #8

Closed lcary closed 5 years ago

lcary commented 5 years ago

Background

There is a pull request out to refactor the EC codebase: https://github.com/ellisk42/ec/pull/49

Once that EC pull request is merged, this puddle-world pull request should also be merged to ensure no breakages occur.

Testing

I ran the following tests as suggested by @CatherineWong:

python ecLearner.py --local --iterations 1 -t 5 --testEvery 5 --no-consolidation --no-recognition --solver python --taskBatchSize 5
python ecLearner.py --local --iterations 1 -t 5 --testEvery 5 --no-consolidation  --solver python --recognitionTimeout 5 --taskBatchSize 5
python ecLearner.py --local --iterations 1 -t 5 --testEvery 5  --solver python --recognitionTimeout 5 --compressor ocaml --taskBatchSize 5

I also fixed and ran the unit test suite on an AWS node, but noticed there are still a few remaining broken tests:

nosetests
...
Ran 53 tests in 2.565s

FAILED (errors=5, failures=11)
CatherineWong commented 5 years ago

Integrated these changes into https://github.com/hans/puddle-world/pull/17; closing.