search

hanschen / ksuperkey

Linux utility that allows you to use the Super key both to open the start menu and as a modifier key in keyboard shortcuts
GNU General Public License v3.0
347 stars 31 forks source link

Improve usability of ksuperkey.desktop file #20

Closed dhouck closed 4 years ago

dhouck commented 4 years ago

Two changes in this PR:

I can understand if you want me to separate this PR into the two commits, or make one with just one or the other, but I think both are useful.

hanschen commented 4 years ago

Thanks for the PR. I'm hesitant to install the .desktop in /etc/xdg/autostart because I don't like when applications enable autostart themselves. For ksuperkey, the user may want to customize the keyboard combination it triggers, so I think it makes sense for users to add it themselves (or distro packages to do it for them).

I'm fine with the second change. Actually, maybe OnlyShowIn should be dropped altogether? If you could create a separate PR for this change I'll merge it. (Closing this PR in the meanwhile.)

Also, the second point is interesting. Now that KDE Plasma has this functionality built-in, ksuperkey may be of more interest to e.g. XFCE users. Is the default keyboard shortcut to open the application in XFCE also Alt+F1?

dhouck commented 4 years ago

Yeah, that makes sense re: autostarting. I wanted to get it onto the system if it was installed from a package, but that makes sense, and installing it to /usr/share/applications so people can symlink it would clutter the menu. I guess that should be left up to packagers.

On my Arch Linux system, by default both Alt+F1 and Ctrl+Escape open the applications menu. Given that Arch rarely modifies that kind of thing, I expect that’s the default in XFCE in general unless other distributions mess with it.

In any case, I made #21 with just the .desktop file changes

hanschen commented 4 years ago

Great, many thanks. I've merged your other pull request and also added a mention of Xfce in the README.