search

hanschen / ksuperkey

Linux utility that allows you to use the Super key both to open the start menu and as a modifier key in keyboard shortcuts
GNU General Public License v3.0
347 stars 31 forks source link

Prevent make clean from failing when the file to remove does not exist #8

Closed Quintasan closed 9 years ago

Quintasan commented 9 years ago

Well, I never realized I would change something here but with my maintainer hat on I can fully say I don't want my package to fail building on make clean.

Could you make a release with this change so I can package that for Debian/Ubuntu?

Quintasan commented 9 years ago

Or hell, even scratch this and just make a release. just realized the tarball has old Makefile.

hanschen commented 9 years ago

I'll try to make a new release as soon as I can, probably tomorrow if I can find the time. Thanks for the heads up and for packaging ksuperkey!

Mehanik commented 9 years ago

Also you can use my repository for Ubuntu: https://launchpad.net/~mehanik/+archive/ubuntu/ksuperkey

hanschen commented 9 years ago

I've made a new release over at KDE-apps: http://kde-apps.org/content/show.php/ksuperkey?content=154569

Just to make sure I understood your comment correctly, the -f flag is not necessary (i.e., I can close this pull request), correct?

Quintasan commented 9 years ago

Yeah sure, the existence test seems like an overkill here since you can just rm -f the file and it will not exit with an error when the file does not exist. But don't fix what's not broken :)

hanschen commented 9 years ago

Thanks for confirming, please let me know if there are any other packaging issues.