search

hansemannn / titanium-crashlytics

Use the native Crashlytics SDK in Titanium (iOS / Android).
MIT License
18 stars 18 forks source link

Android: hook path in home directory #45

Closed m1ga closed 2 years ago

m1ga commented 2 years ago

When compiling with Atom (didn't check VSCode) the path of the hook will be wrong: https://github.com/hansemannn/titanium-crashlytics/blob/master/android/hooks/gradle_plugins.js#L22

Atom: /home/miga/build/android/build.gradle :x:

using the CLI inside the app folder: /home/miga/dev/titanium/test_firebase_messaging/build/android/build.gradle :heavy_check_mark:

We might need a better way to check for the project dir

jordanbisato commented 2 years ago

Same problem here, but with a little difference on the path on atom.

Atom: /build/android/build.gradle ❌

using the CLI inside the app folder: /Users/jordanbisato/Projetos/CVP-Aplicativo-Front/build/android/build.gradle ✔️

m1ga commented 2 years ago

just tested it with Atom and VSCode. Looks like it is only an Atom issue so I'll move the issue to the package and close this one.

New issue: https://github.com/appcelerator/atom-appcelerator-titanium/issues/527