Closed hansemannn closed 5 years ago
@m1ga This one still doesn't want to build - even with the updated library and core. Meeh!
what happens when you add "play-services-measurement-api-16.3.0.aar" from ti.playservices to the lib dir??
@fahad86 Do you think this will change something? It seems to not find the com.google.firebase.analytics
package in general.
@hansemannn yes. That's where you can find the class. I was able to get it to build doing that. You can unzip that .aar and inspect the classes.jar file using a tool like JD-GUI
Not sure why Google would put com.google.firebase.analytics classes into play-services-measurement-api-
@fahad86 This was just fixed in the new Ti.PlayServices release (thanks to @garymathews!). I will retry to package it next week.
@hansemannn
Have you had a chance to package these changes into a release? I updated appcelerator today which bumped play services to 16.1.2. I then went ahead and updated all the firebase modules to the latest versions but I was seeing the following build error:
[ERROR] Uncaught translation error: java.lang.IllegalArgumentException: already added: Lcom/google/firebase/analytics/FirebaseAnalytics; [ERROR] Uncaught translation error: java.lang.IllegalArgumentException: already added: Lcom/google/firebase/analytics/FirebaseAnalytics$Event; [ERROR] Uncaught translation error: java.lang.IllegalArgumentException: already added: Lcom/google/firebase/analytics/FirebaseAnalytics$Param; [ERROR] Uncaught translation error: java.lang.IllegalArgumentException: already added: Lcom/google/firebase/analytics/FirebaseAnalytics$UserProperty;
@hansemannn I'm able to compile without any problems (tested using Ti SDK 7.5.2.v20190306131103). Apply this patch and try: https://quickfileshare.org/1LM2/patch.diff
@hansemannn I'm able to compile without any problems (tested using Ti SDK 7.5.2.v20190306131103). Apply this patch and try: https://quickfileshare.org/1LM2/patch.diff
could you upload a zip with the build? Or maybe submit a PR. I'm trying to build it but I have the same error even with your diff.
@Brianggalvez https://github.com/hansemannn/titanium-firebase-analytics/pull/42 please make sure that you have the latest ti.playservices module in the Ti SDK
@fahad86 can you approve this? I think we are fine here.