search

hansemannn / titanium-firebase-core

Use the Firebase Core SDK in the Titanium SDK 🚀
Other
31 stars 23 forks source link

Configure crashes when sending integer instead of string #14

Closed ghost closed 6 years ago

ghost commented 6 years ago

Function configure() results in an error when I pass GCMSenderID as an integer:

var fcc = require('firebase.core');
        fcc.configure({
            APIKey: 'aaabbbccc',
            projectID: 'proj-id',
            googleAppID: 'a:bbbbasdfcccce',
            GCMSenderID: 2221122211239
        });

this is solved by:

GCMSenderID: '2221122211239'

I will create a PR for the readme, but a code fix might be handy too.

hansemannn commented 6 years ago

The native side requires a String value, so we should be strict and requiring the same. I am welcome accepting a pull request adding the types to the configuration keys!

ghost commented 6 years ago

https://github.com/hansemannn/titanium-firebase-core/pull/15