hansemannn / titanium-google-signin

Use the native Google Sign In SDK in Appcelerator Titanium.
Other
30 stars 16 forks source link

Must use Apple SSO if using Google SSO #37

Open ericpolkadoc opened 3 years ago

ericpolkadoc commented 3 years ago

Hi,

We are going to be implementing Google SSO with the modules here (works great) however we came across an Apple guideline that may or may not have been available at the time this module was created -- stating

"4.8 Sign in with Apple Apps that use a third-party or social login service (such as Facebook Login, Google Sign-In, Sign in with Twitter, Sign In with LinkedIn, Login with Amazon, or WeChat Login) to set up or authenticate the user’s primary account with the app must also offer Sign in with Apple as an equivalent option."

https://developer.apple.com/app-store/review/guidelines/#sign-in-with-apple

Might be helpful if this was in the read me of this repo to prevent any rejected submissions, not sure if anyone using this module has had any issues with submissions when only including Google SSO.

Thanks, Eric

hansemannn commented 3 years ago

Yep, that's a known guideline since the start of "Sign in with Apple". Feel free to change the readme to link to that guideline, I am happy to merge it then :-)