search

hansemannn / titanium-googlemaps

🗺 Use the Google Maps SDK in Titanium
Other
87 stars 26 forks source link

Build failed with 6.0.4 GA #89

Closed quentinkb closed 7 years ago

quentinkb commented 7 years ago

I have this error when i try to build my project with 6.0.4 GA once i've included the module.

This is what i get building directly on my iPhone (5s)

[ERROR] :  ** BUILD FAILED **
[ERROR] :  The following build commands failed:
[ERROR] :   Ld build/Intermediates/LPA.build/Debug-iphoneos/LPA.build/Objects-normal/armv7/LPA normal armv7
[ERROR] :   Ld build/Intermediates/LPA.build/Debug-iphoneos/LPA.build/Objects-normal/arm64/LPA normal arm64
[ERROR] :  (2 failures)

This is what i get building on the simulator : 

[ERROR] :  ** BUILD FAILED **
[ERROR] :  The following build commands failed:
[ERROR] :      Ld build/Products/Debug-iphonesimulator/LPA.app/LPA normal x86_64
[ERROR] :  (1 failure)

I have included the module (3.4.0) using appcelerator IDE.

yozef commented 7 years ago

Hmmm, I haven't stumbled on this... currently using Ti SDK 6.0.4.GA with ti.googlemaps 3.4.0

Have you built the module yourself or downloaded the one from Releases

Have you added run-on-mainthread to true tiapp.xml?

<ios>
        <run-on-mainthread>true</run-on-mainthread>
          ....
quentinkb commented 7 years ago

I tried on another computer on another project and got the same issue.. i'm using macOS Sierra 10.12.4

yozef commented 7 years ago

Did it work prior to 6.0.4.GA?

Have you checked if run-on-mainthread is set to true in tiapp.xml?

quentinkb commented 7 years ago

First time i try to use this module, so i can't tell. run-on-main-thread is well set to true

yozef commented 7 years ago

there you have it... make sure you add this line in tiapp.xml:

<ios>
        <!-- Add this Line Below -->
        <run-on-mainthread>true</run-on-mainthread>

        <enable-launch-screen-storyboard>false</enable-launch-screen-storyboard>
        <plist>
            <dict>
quentinkb commented 7 years ago

just edited my comment above, i currently have this line: <property name="run-on-main-thread" type="bool">true</property>

quentinkb commented 7 years ago

i did so, 

  <ios>
        <run-on-mainthread>true</run-on-mainthread>
        <enable-launch-screen-storyboard>true</enable-launch-screen-storyboard>
        <use-app-thinning>true</use-app-thinning>

still get this error:

[ERROR] :  ** BUILD FAILED **
[ERROR] :  The following build commands failed:
[ERROR] :   Ld build/Products/Debug-iphonesimulator/LPA.app/LPA normal x86_64
[ERROR] :  (1 failure)

btw, if i take a look into the directory : build/Products/Debug-iphonesimulator/LPA.app/ the "LPA" file does not exist

quentinkb commented 7 years ago

If i build with : titanium build --platform ios --build-only i get this error : 

[ERROR] : Cannot find module '/Users/copark/Documents/Appcelerator_Studio_Workspace/copark/undefined'
[DEBUG]     at Function.Module._resolveFilename (module.js:325:15)
[DEBUG]     at Function.Module._load (module.js:276:25)
[DEBUG]     at Function.Module.runMain (module.js:441:10)
[DEBUG]     at startup (node.js:139:18)
[DEBUG]     at node.js:974:3
[ERROR] Alloy compiler failed
quentinkb commented 7 years ago

btw, if i try to build the project myself, this is the result: appc run -p ios --build-only 

[INFO]  Project directory: /Users/copark/Downloads/titanium-google-maps-master/ios
[INFO]  Module ID: ti.googlemaps
[INFO]  Creating universal library
[INFO]  Verifying universal library
[INFO]  Creating module zip
[INFO]  Writing module zip: /Users/copark/Downloads/titanium-google-maps-master/ios/ti.googlemaps-iphone-3.4.0.zip
2017-05-23T15:15:36.401Z | ERROR  | An uncaught exception was thrown!
undefined
2017-05-23T15:15:36.402Z | ERROR  | undefined
iMac-de-COPARK:ios copark$
hansemannn commented 7 years ago

Don't use <run-on-mainthread>true</run-on-mainthread> in <ios/>, use <property name="run-on-main-thread" type="bool">true</property> on the top-level. Please also try ti.googlemaps 3.3.x instead of 3.4.0, maybe there was a packaging error there.

quentinkb commented 7 years ago

Got the exact same issue with version 3.3.1 but compiling with 3.0.0

appsgit1 commented 7 years ago

To fix this issue, Add the ti.googlemap module inside your project module folder. Not in the global. This is working fine.

quentinkb commented 7 years ago

Installing the module locally actually works. for version 3.4.0 !

hansemannn commented 7 years ago

Very very interesting. Let me try to reproduce with a global installation, I also usually test with local references.

hansemannn commented 7 years ago

Fixed it, PR coming asap.

hansemannn commented 7 years ago

Fix-version determined to 3.4.1, release today. Thanks guys!