search

hansenlab / minfi

Devel repository for minfi
58 stars 70 forks source link

qcReport() is broken #145

Closed PeteHaitch closed 6 years ago

PeteHaitch commented 6 years ago

Calling qcReport(rgSet) results in a PDF where no data are plotted for the first 2 pages. I think it's because sampGroups is NULL by default:

https://github.com/hansenlab/minfi/blob/bf9329ada4f0e79a4d504e3aabf71f7d7bf566d0/R/qc.R#L3-L9

This is broken in the version of minfi available from Bioconductor (v1.25.1)

PeteHaitch commented 6 years ago

reprex:

qcReport(minfiData::RGsetEx)

looking into it

kasperdanielhansen commented 6 years ago

This is one of the first functions we (or specifically Martin Aryee) wrote back in the days. I am not sure anyone is using it these days. So for me it has very low priority.