Use DelayedMatrixStats everywhere

hansenlab / minfi

Devel repository for minfi

58 stars 67 forks source link

Closed PeteHaitch closed 6 years ago

PeteHaitch commented 6 years ago

WARNING: This will break digest-based tests since this switch incurs numerical differences (https://github.com/hansenlab/minfi/issues/153)

Use [col|row][Means2|Sums2] everywhere
Use rows and cols arguments of [col|row][Means2|Sums2] instead of 'subset then compute column/row summary'
Use !colAlls(x, value = 0) instead of colSums(x == 0) != nrow(x)
Use rowCounts(x, value = NA) instead of rowSums(is.na(x))

PeteHaitch commented 6 years ago

Don't merge, gotta fix a bug

PeteHaitch commented 6 years ago

Done. Want to take a look before merging?