search

hansenlab / minfi

Devel repository for minfi
58 stars 70 forks source link

Green and Red columns inverted in controlStripPlot #209

Open MGiulia opened 4 years ago

MGiulia commented 4 years ago

Hi, I noted that the plots produced by the controlStripPlot function have inverted colors (dots in the Green column are coloured in red and viceversa).

Rplot

These are my session info: R version 4.0.0 (2020-04-24) Platform: x86_64-apple-darwin17.0 (64-bit) Running under: macOS Mojave 10.14.3 minfi_1.34.0

Please note that with previous versions of R and minfi this issue did not occur. For example, using the same input data but R 3.3.6 and minfi_1.32.0, I previously achieved this plot: immagine

Thank you a lot! MGiulia

Mike-L-V commented 3 years ago

I have the same problem my guess is some update changed how things are ordered so now Green is plotted before Red, maybe because it's alphabetical? I believe the column labels are correct and the colors are wrong. The controlStripPlot function manually specifies colors so if the plotting order changed the colors won't match any more. At the end of the function in the plotting section where it says col = c("darkred", "darkgreen") if you reverse the colors it'll plot properly.