search

hansetag / iceberg-catalog

A Rust implementation of the Iceberg REST Catalog specification.
Apache License 2.0
145 stars 9 forks source link

Support SQL Server #238

Open pp-gborodin opened 1 month ago

pp-gborodin commented 1 month ago

Thank you for your work, awesome project!

We don't have postrges in house, but we do have SQL Server, are there any plans to use ORM like diesel to support more backends? Thanks

pp-gborodin commented 1 month ago

Probably sea-orm since you have async API

c-thiel commented 1 month ago

@pp-gborodin we don't really like the use of ORMs because they take away alot of flexibility. For example, we don't have types for many queried objects, instead, sqlx builds them on the fly.

To support SQL-Server, we could still add another implementation - we do have the abstraction layer for it. It requires implementing ~20 Methods, which might however need quite complex queries. We are open for a PR and might eventually implement it ourselves, but it is not on top of our priorities currently.

grihabor commented 2 weeks ago

Gotcha. You're talking about this Catalog trait implementation, right?

c-thiel commented 2 weeks ago

Gotcha. You're talking about this Catalog trait implementation, right?

Exactly!