search

hansjoachimbutz / osmdroid

Automatically exported from code.google.com/p/osmdroid
0 stars 0 forks source link

Clean up MapController code #471

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
There are a few things we can do to clean up the MapController.

1. Implement the remaining API calls for the Google API v1 MapController.
2. Remove the AbstractAnimationRunner. It accesses MapView UI elements and 
fields on a background thread and is not thread-safe.
3. Move all the zoom-in/out animation code to the controller and out of the 
MapView.
4. Let the MapView.getController() return an IMapController so that it can 
return custom implementations of MapController.

Original issue reported on code.google.com by kurtzm...@gmail.com on 30 Aug 2013 at 6:41

GoogleCodeExporter commented 9 years ago

Original comment by kurtzm...@gmail.com on 30 Aug 2013 at 6:42

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1294.

Change the way we do zoom animations to use canvas scaling. This will keep zoom 
and pinch zoom operations consistent and will eliminate issues where overlay 
painting will scale when zooming regardless of trying to counteract it in the 
canvas.
Update issue 471
Updated MapController. Removed unsafe AbstractAnimationRunner code, moved all 
zoom animation code to MapController.

Original comment by kurtzm...@gmail.com on 30 Aug 2013 at 7:14

GoogleCodeExporter commented 9 years ago

Original comment by kurtzm...@gmail.com on 30 Aug 2013 at 7:14

GoogleCodeExporter commented 9 years ago 
Hi,

With the latest updates the osmdroid-third-party does not compile anymore.
The org.osmdroid.google.wrapper.MapController class does not implement all 
methods of org.osmdroid.api.IMapController interface.

Regards.

Original comment by devemu...@gmail.com on 31 Aug 2013 at 8:45

GoogleCodeExporter commented 9 years ago 
This issue was updated by revision r1298.

Added missing methods from third-party MapController.

Original comment by kurtzm...@gmail.com on 2 Sep 2013 at 2:48