search

hanslub42 / rlwrap

A readline wrapper
GNU General Public License v2.0
2.53k stars 149 forks source link

Minor issue about english #174

Closed 6502 closed 1 year ago

6502 commented 1 year ago

There is a minor issue about English in the notification message after wrapping a signal

myerror(WARNING|NOERRNO, "%s crashed, killed by %s%s.\n%s itself has not crashed, but for transparency,\n" ...

should be

myerror(WARNING|NOERRNO, "%s crashed, killed by %s%s.\n%s itself has not crashed but, for transparency,\n" ...

i.e. with the comma after "but" (reason is that "for transparency" is an interrupter and it's the part that should be wrapped in commas). It simply felt weird for me so I double checked with a grammar website.

English is not my native language; if this is wrong just ignore.

Fantastic tool by the way...

hanslub42 commented 1 year ago

Fixed by 94fa64592bf6de78d50b6f7f87815bb2b2637a21 . Closing