hansonrobotics / CppMT

Other
0 stars 1 forks source link

merge outstanding pull requests #5

Open linas opened 8 years ago

linas commented 8 years ago

There are five outstanding pull requests, here:

https://github.com/gnebehay/CppMT/pulls

could they be merged here (if they have not been, yet)?

tesYolan commented 8 years ago

I haven't requested a pull request to the upstream repo as many of the changes i have done are related to making the library suitable to be ROS wrapped(specifically to make it easier to factor out adding area's to tracker, to deleting based on ROS threshold values, even holding names). Oonce functionalities are tested well i would request one by relating it to our ROS wrapper for their library.

On Thursday, July 14, 2016 6:59 PM, Linas Vepštas <notifications@github.com> wrote:

There are five outstanding pull requests, here:https://github.com/gnebehay/CppMT/pullscould they be merged here (if they have not been, yet)?— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

linas commented 8 years ago

Hmm. That's not the point. The point is that this appears to be an abandoned project -- gnebehay has not touched it since August 2015 -- other people have been hacking on it as well; this pull requests should be merged, and the whole package should be properly maintained.

Failing to deal with the early on will only cause pain later on, making merging hard, forcing old bugs to be rediscovered and fixed multiple times, etc. Letting unmerged pulls to accumulate is always a bad idea, and it always leads to chaos.

tesYolan commented 8 years ago

So are you suggesting that we contact gnebehay and be involved in maintaining the original repo and move our changes early on to the original repo thus the original author and people hacking on it further can comment much more? If that's the suggestion i can remove the nitty gritty hacks to make the cmt_tracker stuff work from the CppMT and take it to the cmt_tracker and plug it in there and let higher level architectural changes we made remain in the CppMT and maintain it there.

On Monday, July 18, 2016 12:48 AM, Linas Vepštas <notifications@github.com> wrote:

Hmm. That's not the point. The point is that this appears to be an abandoned project -- gnebehay has not touched it since August 2015 -- other people have been hacking on it as well; this pull requests should be merged, and the whole package should be properly maintained.Failing to deal with the early on will only cause pain later on, making merging hard, forcing old bugs to be rediscovered and fixed multiple times, etc. Letting unmerged pulls to accumulate is always a bad idea, and it always leads to chaos.— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

linas commented 8 years ago

You can try to contact gnebehey, but he probably won't answer, given that he stopped paying attention about a year ago. That means that someone should take over maintainership, and since you are the most active, that would be you....

I don't know what hacks you made -- in a perfect world, the code would be hack-free, and properly constructed.

tesYolan commented 8 years ago

Okay.  I would resolve the work around i have made this week and also try to communicate with gnebay(though he hasn't been active on his site either) and communicate with community members to test out our code and also help in maintaining it.

On Monday, July 18, 2016 1:42 AM, Linas Vepštas <notifications@github.com> wrote:

You can try to contact gnebehey, but he probably won't answer, given that he stopped paying attention about a year ago. That means that someone should take over maintainership, and since you are the most active, that would be you....I don't know what hacks you made -- in a perfect world, the code would be hack-free, and properly constructed.— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

tesYolan commented 8 years ago

I have been added to the contributor's list by Geoge Nebehay to the original. I would be tend to the issues raised here and there over the next week. I would close this issue once we sync our repo with theres.

linas commented 8 years ago

thank you!