Upgrading errors

[vytasrgl]

After upgrading to new hrtool following issues are present:

• motor_safety cant start with error: "This package should not be accessible on python3" on import rospy
• pololu_motors: "No mudule named serial"
• rosbridge server hasnt started

Not sure if we should separate to individual issues but needs to be solved for release

[wenwei-dev]

Change the motor_safety.py to let it run in Python 2 should solve this.

I haven't seen problems with running it in Python2.

On Tue, 15 Aug 2017 at 03:57, vytasrgl notifications@github.com wrote:

Assigned #2 https://github.com/hansonrobotics/hrtool/issues/2 to @wenwei-dev https://github.com/wenwei-dev.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/hansonrobotics/hrtool/issues/2#event-1205425499, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhJ9y4pAWbSslgjArfxNfxKMtaGVbi1ks5sYKa5gaJpZM4O2002 .

-- Sent from Gmail Mobile

[wenwei-dev]

Regarding "serial module is not found", check if the dependency python-serial is installed. If not, check if head-deps-all is installed. This dummy package installs python-serial.

On Tue, 15 Aug 2017 at 08:03, Wenwei Huang wenwei@hansonrobotics.com wrote:

Change the motor_safety.py to let it run in Python 2 should solve this.

I haven't seen problems with running it in Python2.

On Tue, 15 Aug 2017 at 03:57, vytasrgl notifications@github.com wrote:

Assigned #2 https://github.com/hansonrobotics/hrtool/issues/2 to @wenwei-dev https://github.com/wenwei-dev.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/hansonrobotics/hrtool/issues/2#event-1205425499, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhJ9y4pAWbSslgjArfxNfxKMtaGVbi1ks5sYKa5gaJpZM4O2002 .

-- Sent from Gmail Mobile

-- Sent from Gmail Mobile

[vytasrgl]

python serial is installed, however it is not in the path as path contains only /opt/ros and /opt/hansonrobotics/ros

for motor_safety smooth function will not work on Python2, we can run python3 from virtualenv for the motor safety, or just have python3 path different from python2 path

[wenwei-dev]

We also use the path of system Python package because those are installed by apt-get. I think I've added /usr/lib/.../dist-packages to PYTHONPATH. Check if your hr_launchpad is the latest.

Because motor safety is launched by roslaunch, if we add Python3 to the path, all other ros nodes that are also launched by roslaunch will share this path. This will casue some wired problems. So I would like to know which function won't work? How to make it work in Python2. I don't think numpy runs differently in Python2 and Python3. I suspect it is from the difference in python's division.

Wenwei

On Wed, 16 Aug 2017 at 01:20, vytasrgl notifications@github.com wrote:

python serial is installed, however it is not in the path as path contains only /opt/ros and /opt/hansonrobotics/ros

for motor_safety smooth function will not work on Python2, we can run python3 from virtualenv for the motor safety, or just have python3 path different from python2 path

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/hansonrobotics/hrtool/issues/2#issuecomment-322531038, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhJ9yJoHBqEhY3NaxFcPi12MF42vbEAks5sYdN1gaJpZM4O2002 .

-- Sent from Gmail Mobile

[linas]

Umm these issues have been fixed, right? Can this be closed?

[linas]

Never mind, I assume this is fixed, am closing this, if there are still problems, please open a new bug (or reopen this one)