search

hanspi42 / signalflowgrapher

This Python tool allows you to draw signal-flow graphs, calculate transfer functions (SymPy code is generated for further use in Jupyter notebooks), do graph manipulations (e.g., node elimination and graph transposition), and save a graph as TikZ for use in LaTeX documentation.
Artistic License 2.0
30 stars 6 forks source link

Crash when entering branch weights #1

Closed hanspi42 closed 3 years ago

hanspi42 commented 4 years ago

When trying to enter 1/(G1+G2), it can happen that the application crashes after 1/( has been entered.

Error message:

  File "src\signalflowgrapher\gui\sympy_expression_validator.py", line 20, in validate
    parse_expr(s)
  File "envs\sfg\lib\site-packages\sympy\parsing\sympy_parser.py", line 1008, in parse_expr
    return eval_expr(code, local_dict, global_dict)
  File "envs\sfg\lib\site-packages\sympy\parsing\sympy_parser.py", line 902, in eval_expr
    expr = eval(
  File "<string>", line 1, in <module>
TypeError: unsupported operand type(s) for /: 'One' and 'tuple'

Idea: use try / except in sympy_expression_validator.py

hanspi42 commented 3 years ago

try/except is already used, but TypeError is not in the exception list.