hansu / vscode-git-graph

Fork of Michael Hutchisons repository with some updates.
Other
68 stars 11 forks source link

Official fork? #17

Open the-moog opened 1 year ago

the-moog commented 1 year ago

See https://github.com/vscode-ext-studio/vscode-git-graph/issues/3#issuecomment-1366826332 I think this says that authors of both the orgin and fork fork have no interest in public facing maintainance of this project.

Is the intention of this fork to resolve that?

the-moog commented 1 year ago

See also https://github.com/egno/vscode-git-graph https://github.com/QrackEE/vscode-git-graph

hansu commented 1 year ago

Sorry for my late reply, but I didn't get a notification about your issue.

See https://github.com/vscode-ext-studio/vscode-git-graph/issues/3#issuecomment-1366826332 I think this says that authors of both the orgin and fork fork have no interest in public facing maintainance of this project.

This comment doesn't seem to exist any more. But https://github.com/vscode-ext-studio/vscode-git-graph at least enabled issues.

Is the intention of this fork to resolve that?

The intention is at least to go at least a bit ahead with further development of this great extension. It's a bit sad that mhutchie suddenly disappeared from the horizon and that further development speaded into several forks.

It would be nice if this repository could be a base for this extension for the future. But I won't have the time to dig into Typescript to do active development work, but I could act as a tester and manager. The features that were added in this fork are implemented by @LariWa resp. by a pull request of the official repo, not by me. I didn't publish it on the marketplace to avoid more confusion with a third version of the same extension. I also don't see a way to replace mhutchie's extension on the marketplace.

the-moog commented 1 year ago

There is a discussion thread on https://github.com/microsoft/vscode-discussions/discussions/1 regarding deprecation. I can see several entries where a vscode maintainer is manually deprecating extensions that have been forked and the original is clearly no longer maintained and the fork has improvements.

hansu commented 1 year ago

Thanks for that hint. Maybe that is a way to go on.

hansu commented 1 year ago

See https://marketplace.visualstudio.com/items?itemName=hansu.git-graph-2

Unfortunately it was not possible to use the same name and ID.

thesoftwarejedi commented 1 year ago

found this while setting up a new machine with vscode. glad someone picked it up for improvement!!

pktiuk commented 1 year ago

@the-moog
There cannot be any "official" fork until the owner of legacy repo (@mhutchie) will transfer ownership/move to github organization etc.
Luckily thank to open source license this fork can be developed independently. In this case it is a good idea to make it distinct from original plugin. Calling it git-graph 2 is fine in my opinion.

If this repo will be alive and open for users and contributors (unlike the ones mentioned earlier) this project will gain some traction :)

hansu commented 1 year ago

Luckily thank to open source license this fork can be developed independently.

Unluckily I missed the license note where mhutchie prohibits further publishing of his extension. I am not sure how long this fork will be alive. Hopefully mhutchie returns at some time and picks it up.

There is a discussion about that here: https://github.com/microsoft/vscode-discussions/discussions/1#discussioncomment-5917977

pktiuk commented 1 year ago

I just assumed, that it is placed under one of the well established licenses, but it appears that this one is a custom one.

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to use, copy, modify, merge, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

Permission is NOT GRANTED to publish, distribute, sublicense, and/or sell derivative works of the Software.

The second paragraph is very problematic :/

hansu commented 1 year ago

I just assumed, that it is placed under one of the well established licenses, but it appears that this one is a custom one.

Yes I thought the same.

pktiuk commented 1 year ago

That's why addon git-log-graph was started from scratch
https://github.com/phil294/git-log--graph#relation-to-mhutchiegit-graph

Maybe it would be better to just focus on that project.

the-moog commented 1 year ago

That's why addon git-log-graph was started from scratch https://github.com/phil294/git-log--graph#relation-to-mhutchiegit-graph

Maybe it would be better to just focus on that project.

@pktiuk Good find. @phil294 may have something worth supporting. There are a few other's I've talked with who also forked mhutchie and got fristrated with the lack of response to their PRs who will be interested. I see you've raised some tickets on that project may be worth mentioning this thread and the discussion

hansu commented 1 year ago

That's why addon git-log-graph was started from scratch https://github.com/phil294/git-log--graph#relation-to-mhutchiegit-graph

Yeah this one looks promising and has potential.

However I like the idea of this extension to have the file diff list in a different pane: https://github.com/raymon-sun/vscode-git-history

pktiuk commented 1 year ago

So what are you going to do now, after removing your fork from merketplace?
Are you going to contribute to this new addon git log --graph or do you want to do something else? (I am just curious)

hansu commented 1 year ago

Are you going to contribute to this new addon git log --graph

Yeah maybe

the-moog commented 1 year ago

@hansu Hi, I've been trying to find some help with MH's fork. I have an email from an anti-abandonware organisation that I have been given to share. Would you be willing/prepared to create a discussion topic on your fork so that we can track attempts to contact MH? It seems a bit wrong to keep hijacking the VSCode discussion topic. If you would rather somebody else did then I am happy to, that is unless you are aware this is already done? I thought I should give your the opportunity first as your input to this project is more material than mine. If this is done then perhaps it's possible to move existing posts from vscode into a dedicated discussion.

The email says that if we track attempts to contact MH and they are ignored then we can consider his work abandoned. It's up to him to make a counter claim. The larger the number of attempts via differing means, and the longer that takes the weaker any counterclaim becomes. So capturing efforts of those interested at the outset is important.

I've tried email and linkedin. Other than github I'm not on any other social media platforms.

hansu commented 1 year ago

Yes we can start a discussion within this fork. If you want, you can simply create a new one here: https://github.com/hansu/vscode-git-graph/discussions/new/choose

the-moog commented 1 year ago

Is there a way to add a category - none of those really match?

hansu commented 1 year ago

Sure, what do you have in mind? Is "General" not suitable enough?