search

hansu / vscode-git-graph

Fork of Michael Hutchisons repository with some updates.
Other
64 stars 9 forks source link

Enhance search function for not-loaded commits #2

Open hansu opened 2 years ago

hansu commented 2 years ago

The current search function searches only in commits that are already loaded. So, search the complete history and load the regarding commit + "git-graph.repository.commits.loadMore" newer commits. (It takes around 7 seconds on my system to load 40k commits but if such many commits are loaded, git-history reacts quite slow) For reference in the commit message filter of https://github.com/vscode-ext-studio/vscode-git-graph is searches beyond the displayed commits.

pktiuk commented 2 years ago

I see this feature issue is linked with https://github.com/mhutchie/vscode-git-graph/issues/607

@hansu
Are you going to somehow upstream your changes either upstream (although it seems abandoned for now) or to any other active fork?
Like for example https://github.com/vscode-ext-studio/vscode-git-graph

hansu commented 2 years ago

I will create a PR to upstream as well, but I have no real hope that it will be merged in the near future. But I will merge it here as one of the most active forks atm :). Then I will create a new release. PS: check out my current release ;-)

pktiuk commented 2 years ago

PS: check out my current release ;-)

For now I was just browsing commits and I found some good changes, but unluckily your version is nor listed in marketplace (even link in About section of your repo points at market site of legacy one)

hansu commented 2 years ago

Yeah this is just meant as a tempory place to provide the changes as vsix file. I still have the hope that the official repo will become alive again. Otherwise I should think of publishing it on the market place, but I want to avoid the confusion to have three forks available there.

pktiuk commented 2 years ago

You could also think about joining https://github.com/vscode-ext-studio, but it depends on their openness for other contributors (they have alreadypublished their version in marketplace, so it would save you some changes) :)

hansu commented 2 years ago

Yes I know that, but they have done exactly zero for documenting their changes. I think that'sa no go when publishing. Furthermore they have changed the code structure so that the changes suitable for upstream cannot be applied. And they have disabled issues. These are the reasons why I wouldn't do that.

pktiuk commented 2 years ago

That's a fair point.

hansu commented 2 years ago

Yes I know that, but they have done exactly zero for documenting their changes. I think that's a no go when publishing.

I have to correct myself. Just two weeks before I wrote this, he adapted the documentation and also enabled issues.

pktiuk commented 2 years ago

You can test their openness by opening PR with some fixes you have already done.

hansu commented 2 years ago

Yeah but the changes on my repo (not done by me, thanks @LariWa) are based on the code of mhutchie - the code structure changes of cweijan would cause a lot of rework to make a suitable PR.

hansu commented 2 years ago

[@pktiuk]

(even link in About section of your repo points at market site of legacy one)

I fixed that and the README as well ;-)