hanyuone / Ways-to-NOT-make-money

A basic Python (2.x/3.x) incremental game.
8 stars 3 forks source link

Update game.py to V0.7.2 #90

Closed hanyuone closed 8 years ago

hanyuone commented 8 years ago

Removed the animation bar thing, and replaced it with a notification box.

Also made the code neater.

hanyuone commented 8 years ago

I think the code in game.py is really messy - I suggest splitting it up into smaller chunks, and just maybe have main() and mainloop() (maybe other required functions) in the main game.py, and have the rest of the functions in different files. That way, everything would be easier to find and code.

What do you guys think (I'm probably only going to talk to @qlstudio, but eh)?

Also, the exe and the single-file-executable folder names should be changed, so that it doesn't contain the version name (the version changes a lot, so the name won't stick for very long - include the version stuff in the README.)

ghost commented 8 years ago

I think the code in game.py is really messy - I suggest splitting it up into smaller chunks, and just maybe have main() and mainloop() (maybe other required functions) in the main game.py, and have the rest of the functions in different files. That way, everything would be easier to find and code.

Definitely - the actual game.py should then just be in a package and renamed __init__.py or __main__.py or whatever showing it is the file you'd have to run, but it could just be game.py

Also, the exe and the single-file-executable folder names should be changed, so that it doesn't contain the version name (the version changes a lot, so the name won't stick for very long - include the version stuff in the README.)

Sure.

SIDE NOTE:

_DO NOT COMMIT TO MASTER UNTIL MERGED!_

hanyuone commented 8 years ago

Oh yeah, the savefile needs to update as well.

ghost commented 8 years ago

What do you mean - savefile???

And sorting would be difficult...

hanyuone commented 8 years ago

Wait... don't pull-request it yet. I need to update the savefile.

hanyuone commented 8 years ago

Because I changed the animation-bar thing, we can probably get rid of these pictures.

ghost commented 8 years ago

We can DELETE the savefile. The savefile is CREATED by the program.

ghost commented 8 years ago

Because Py3 diverged...

hanyuone commented 8 years ago

What do you mean "Py3 diverged"?

ghost commented 8 years ago

Py2 is ahead and behind Py3. Py3 is ahead and behind Py2.

hanyuone commented 8 years ago

Ah. Got that. But does it really have to be exactly the same? I mean, some subtle differences could work.

joshgit commented 8 years ago

What??

hanyuone commented 8 years ago

No wait, ignore that comment, I forgot @joshgit's commit to fix that.

But yeah, the code doesn't have to be exactly the same, like same classes, same functions, that sort of thing. IMO, as long as the GUI is the same, and the code works the same, it's the same to me.

Also, side note, is there a way to move all the "building" functions (I.e. cannotafford1h1, deduction2) to another file?

joshgit commented 8 years ago

Do all the pulls!