search

hanzhi713 / image-collage-maker

A photo mosaic (pixel collage) maker. Use all your friends' profile pictures to approximate your profile picture! 如何用 Python 制作一个炫酷的微信好友图
MIT License
152 stars 14 forks source link

[feature request] Progress bar on "Aligning images on the grid" stage of tile loading #25

Closed Pizzanomicon closed 1 year ago

Pizzanomicon commented 1 year ago

There is a notable lag in the process when loading tiles (Windows GUI) after "Aligning images on the grid... Note: ### transparent tiles will be added to the grid" Perhaps a progress bar would help in indicating if the process was frozen?
Additionally, could CuPy/CUDA acceleration be used in this phase?

hanzhi713 commented 1 year ago

Currently, this is done with a few lines of NumPy magic. See

https://github.com/hanzhi713/image-collage-maker/blob/ea6c45753122135dc21cfd71b3b3edefe1a70fd2/make_img.py#L265-L270

Because there's no loop, no progressbar is shown.

Yes, a progress bar is possible. I just need to rewrite it with python code and not fully vectorized numpy code. Performance is quite similar, just a bit more code.

hanzhi713 commented 1 year ago

Added in v5.2