haochengxia / vscode-pydata-viewer

Display PyData files (.npz .npy .pkl .pth) in VSCode.
https://marketplace.visualstudio.com/items?itemName=Percy.vscode-pydata-viewer
MIT License
14 stars 8 forks source link

fix: encoding problem of pickle #10

Closed jasongzy closed 1 year ago

jasongzy commented 1 year ago

also optimize ndarray print

jasongzy commented 1 year ago

BTW, since the python codes are embedded in pydataPreview.ts, is pyscripts/read_files.py deprecated now? Anyway, I sync them for now.

Suggestion: for the convenience of debugging and testing this python script, personally I think it's a better way to read an external .py in pydataPreview.ts.

Thanks!

haochengxia commented 1 year ago

Thanks for your PR and suggestion, sincerely! And I will consider to use the python script as an external file in the next version.

haochengxia commented 1 year ago

I've used the python script as an external file and moved read_files.py in folder /src/pyscripts to /pyscripts. (since V0.0.8) Hope it brings some convenience. :smile: