haoel / leetcode

LeetCode Problems' Solutions
17.58k stars 4.91k forks source link

[Word Break II] Your code seems outdated and needs more test cases. #41

Open ghost opened 9 years ago

ghost commented 9 years ago

https://github.com/haoel/leetcode/blob/0858fdb3d9c4dba43135001e370a80ce518d5e82/src/wordBreak/wordBreak.II.cpp#L143

Your DP solution is not really efficient.

I can provide two test cases:

unordered_set<string> dict = {"a","aa","ab"};
string s = "babaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
unordered_set<string> dict = {"a","aa","ba"};
string s = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabab";
haoel commented 9 years ago

You are right, the DP is not efficient. Actually, the recursive solution is more efficient than that DP solution.

yqtaowhu commented 7 years ago

yes,i think the dp is not efficient , it will lead Memory Limit Exceeded, could you have any solution to solve it .

ghost commented 7 years ago

@yqtaowhu Sure, just visit the leetcode forum. 😉