haoheliu / voicefixer_main

General Speech Restoration
https://haoheliu.github.io/demopage-voicefixer/
MIT License
271 stars 52 forks source link

super_resolution should be True? #13

Open m-mandel opened 1 year ago

m-mandel commented 1 year ago

https://github.com/haoheliu/voicefixer_main/blob/b15d20d2456c4158a55d7b66aed67b9b994f9143/config/vctk_base_ssr_unet_super_resolution.json#L20

Should the configuration for super resolution be as follows?

 "ssr":{
      "ssr_task": {
        "dereverberation": false,
        "denoising": false,
        "declipping": false,
        "super_resolution": true
      },

instead of:

 "ssr":{
      "ssr_task": {
        "dereverberation": false,
        "denoising": true,
        "declipping": false,
        "super_resolution": false
      },
haoheliu commented 1 year ago

Hi @mosem Thanks for pointing out. This part of configuration is a little bit redundancy, which means it's not actually used by code. So changing this part will not affect the program behavior. Many apologizes for the confusion. I'll try to fix this issue and resolve the confusion lately.

Haohe