validation loss miscalculation

haoheliu / voicefixer_main

General Speech Restoration

https://haoheliu.github.io/demopage-voicefixer/

MIT License

272 stars 52 forks source link

validation loss miscalculation #19

Closed satvik-venkatesh closed 5 months ago

satvik-venkatesh commented 8 months ago

Thanks for this amazing project!

Currently, the val loss is calculated between estimation and low_quality. But it should be between estimation and sp_target. Could you please confirm?

It looks correct in the gsr_voicefixer.py

haoheliu commented 5 months ago

Oh ncie! Thanks for that!