Mark Row and Cell classes as open so that they can be subclassed

haojianzong / ObjectForm

A simple yet powerful Swift library to build form for your class models.

Apache License 2.0

177 stars 14 forks source link

Mark Row and Cell classes as open so that they can be subclassed #14

Closed RobertAudi closed 4 years ago

RobertAudi commented 4 years ago

The classes in question were marked as public, which is not a problematic when the package is imported directly into a project.

When the package is installed using a package manager (SPM or other) these classes couldn't be subclassed because of the public access level. Marking them as open solves this problem.

Fixes #13

RobertAudi commented 4 years ago

@haojianzong I fixed the code that made the tests fail. I am sorry, I should have been more thorough 😕

haojianzong commented 4 years ago

@RobertAudi No problem, I appreciate your contribution to my tiny project :) I've addressed this issue in #15 so let me close yours.