Rtgdir last call review of draft-ietf-ccamp-l1csm-yang-19 - Githubissues

haomianzheng / IETF-ACTN-YANG-Model

IETF Optical YANG models in ACTN Architecture

4 stars 4 forks source link

Rtgdir last call review of draft-ietf-ccamp-l1csm-yang-19 #123

Closed italobusi closed 1 year ago

italobusi commented 1 year ago

Nits: either "Layer 1" or "layer 1" should be used consistently throughout the document:

Page 5, First sentence: "The benefit is that the same layer 1 transport network resources are"
Page 6, "The L1CSM YANG data model describes the layer 1 connectivity services" References to "RFCXXX", "RFC XXX" and "RFCYYY" need to be fixed.
(In some cases there is a comment that this needs to be updated but not not in all cases. E.g., Page 9)

Page 6, Table has no caption, References need to be fixed ("RFCXXX"/"[RFCYYY]")

Some of the comments from Adrians review (e.g., use of "P" as Protcol but also in different context in Figues are not addressed (yet)).

See: https://mailarchive.ietf.org/arch/msg/ccamp/ocu7N6fEWUGcpAjYikcJ-_yjTT4/

haomianzheng commented 1 year ago

see https://github.com/haomianzheng/IETF-ACTN-YANG-Model/pull/124 for the update on the module.

haomianzheng commented 1 year ago

regarding the last comments, P for 'protocol' or 'physical'. I tentatively removed the 'P node' in Figure 1 to avoid misleading... any better option?

italobusi commented 1 year ago

https://datatracker.ietf.org/doc/html/[draft-ietf-ccamp-l1csm-yang-20](https://datatracker.ietf.org/doc/html/draft-ietf-ccamp-l1csm-yang-20)