search

haomianzheng / IETF-ACTN-YANG-Model

IETF Optical YANG models in ACTN Architecture
4 stars 4 forks source link

Rtgdir LC review comments #133

Closed italobusi closed 8 months ago

italobusi commented 1 year ago

I found the document easy to read and understandable. The last GPON stuff I did was in 2010, so I don't really know the details of the technology anymore.

The interspersing of text into the YANG-tree output is an interesting way to do things. I was concerned as I read that this might mean that description in the YANG itself might be weak, and I found this to be the case. I don't have a good answer as to whether detailed text in the YANG module is better or worse.

Nits:

Section 4.2 has some odd formatting for the definition list, which I'm sure the RPC will clean up.

See: https://mailarchive.ietf.org/arch/msg/ccamp/xixPovLC47O-1d_tN66w68_e1ho/

italobusi commented 1 year ago

Section 4.2 fixed and a new clause 5 added in draft-ietf-ccamp-layer1-types-16

italobusi commented 8 months ago

[x] @italobusi reply to the Rtgdir LC review

See: https://mailarchive.ietf.org/arch/msg/ccamp/41IiGXvFQtWQ7IUoiIxkNI-ZV00/