search

haomianzheng / IETF-ACTN-YANG-Model

IETF Optical YANG models in ACTN Architecture
4 stars 4 forks source link

Add a short explanation why the client-svc presence container should be outside the te presence container #159

Open italobusi opened 8 months ago

italobusi commented 8 months ago

While the PR is approved, it would be better to add a short explanation why the "the client-svc presence container should be outside the te presence container".

I think this description should be added in the I-D rather than in the YANG model

Originally posted by @italobusi in https://github.com/haomianzheng/IETF-ACTN-YANG-Model/issues/156#issuecomment-1885226811

italobusi commented 5 months ago

The advantage of specifying the client-svc outside of te presence container is to make the model design more modular, allowing using the client-svc presence containers also when there underlay network is not OTN and does not require enabling the te presence container.

However, considering the the I-D has already passed CCAMP WG LC, the value of this change is not worth the risk to have the I-D sent back to the WG for discussion.

Therefore the change has been rolled-back with PR #174

The issue would be kept open until the approval of the I-D, just in case we receive some comments in the next phase of the approval process.