search

haosulab / ManiSkill2-Learn

Apache License 2.0
77 stars 15 forks source link

Assertion message misleading in `maniskill2_learn/env/rollout.py` #25

Closed chenjy2003 closed 7 months ago

chenjy2003 commented 7 months ago

There is an assertion in maniskill2_learn/env/rollout.py: 123. The order in the assertion itself and the message is inconsistent, which misleads me a bit.

assert num % self.num_envs == 0, f"{self.num_envs} % {num} != 0, some processes are idle, you are wasting memory!"
xuanlinli17 commented 7 months ago

Thanks for pointing this out!