Issues in chiron_label

[mbhall88]

This module has a note at the top saying it is a temporary script. Is it still temporary or not? If so should we delete it?

If we are not deleting it there are multiple bugs in the function label.

• The variable seq_length is used multiple times but is never declared.
• This line calls the function get_label, but all this function does is return None.

[haotianteng]

It is a script under development, I was trying to cooperate with Sheng Wang with cwDTW, this is a python binding for their labeling software.

2018-02-18 7:55 GMT+10:00 Michael Hall notifications@github.com:

This module has a note at the top https://github.com/haotianteng/Chiron/blob/a19c0ac0dc7f14ceadc02163293aec7c78a5ea4e/chiron/chiron_label.py#L5 saying it is a temporary script. Is it still temporary or not? If so should we delete it?

If we are not deleting it there are multiple bugs in the function label https://github.com/haotianteng/Chiron/blob/a19c0ac0dc7f14ceadc02163293aec7c78a5ea4e/chiron/chiron_label.py#L106 .

• The variable seq_length is used multiple times https://github.com/haotianteng/Chiron/blob/a19c0ac0dc7f14ceadc02163293aec7c78a5ea4e/chiron/chiron_label.py#L123-L127 but is never declared.
• This https://github.com/haotianteng/Chiron/blob/a19c0ac0dc7f14ceadc02163293aec7c78a5ea4e/chiron/chiron_label.py#L162 line calls the function get_label, but all this function does is return None.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/haotianteng/Chiron/issues/18, or mute the thread https://github.com/notifications/unsubscribe-auth/AKo3X0l1F26flTjsEbQC8XS-ZvEsEkliks5tV0rIgaJpZM4SJen7 .

-- Teng Haotian University of Queensland, Queensland, Australia +61 0426116017

[mbhall88]

Ok. Well in that case the two issues I noted will need fixing at some point. Those links are also to the code on the clean_code branch so make sure you fix on that branch.

[haotianteng]

Yes, it will be put into the release version once the labeling software is tested.

Michael Hall notifications@github.com于2018年2月18日 周日19:25写道：

Ok. Well in that case the two issues I noted will need fixing at some point. Those links are also to the code on the clean_code branch so make sure you fix on that branch.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/haotianteng/Chiron/issues/18#issuecomment-366502943, or mute the thread https://github.com/notifications/unsubscribe-auth/AKo3XyaKxTlhXwqT2vq9we83uhPnVr7hks5tV-x1gaJpZM4SJen7 .

-- Teng Haotian University of Queensland, Queensland, Australia +61 0426116017

[mbhall88]

Ok. It's probably best to keep it then.