search

haowenz / chromap

Fast alignment and preprocessing of chromatin profiles
https://haowenz.github.io/chromap/
MIT License
189 stars 20 forks source link

Allow gzipped barcode whitelist file. #127

Closed mourisl closed 1 year ago

mourisl commented 1 year ago

I leave the original ifstream code there in case we still need it in the future.

haowenz commented 1 year ago

btw, did you test this on whitelist files in gz and normal txt formats?

mourisl commented 1 year ago

Yes, I have tested on uncompressed and gzipped whitelist files, and they generated the same results. I'll address the other comments you mentioned later.

haowenz commented 1 year ago

Thank you for adding this feature. Please bump up the version before rebase.

haowenz commented 1 year ago

Will this change also support loading translation table in gz format?

mourisl commented 1 year ago

Not yet. I can add that after the paired-end sam format.