search

haoxuany / anki_image_search

GNU General Public License v2.0
9 stars 7 forks source link

How/where to change the search engine? #2

Open flow7 opened 6 years ago

flow7 commented 6 years ago

Hey there! Thanks heaps for this add-on - it's super useful! Only I have had a few bad experiences with google image search in the last days/weeks - it doesn't provide a very good Link to Picture anymore, I have the impression.

So, my experience with DuckDuckGo Image Search is much better - it's just easier. Question: Where in this add-on could I change the settings for the search engine of the add-on? I would then try to fork it - an experiment for me, I have never done that :)

thanks

haoxuany commented 6 years ago

I may take a look at it again some point later (when I'm back in the states). To be honest debugging this is a real nightmare in China, since Google is completely blocked, and I spend most of my time debugging my proxy connection.

I separated things like this specifically for the purpose you mentioned: everything that you would likely want to modify is in shared.py. For generating the search url to fetch, take a look at image_search_url (takes in the query string, returns the url to fetch). For scrapping the image page for image urls, take a look at scrape_image_urls (takes in the html content of the search page, returns a list of url addresses). It shouldn't be too difficult. I was initially planning to add some ui for search engine switching, but Python is a real pain in the arse to use and more or less my least favorite language, and writing ui code is annoying, so I basically moved on lol.

Feel free to extend it if you wish, I'd be happy to merge it if you implement some ui code for switching engines. Please put configs into shared.mainconfig.

flow7 commented 6 years ago

Never done anything of the kind, but might have a look at it at some points, thanks for getting back!

owensgithub commented 5 years ago

It would be great to see DuckDuckGo images added with (or instead of) Google images as a privacy respecting alternative. Hope something like this can be added as this is a very useful addon.